Update php laravel to latest stable version#24193
Closed
wing328 wants to merge 5 commits into
Closed
Conversation
wing328
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/server/petstore/php-laravel/composer.json">
<violation number="1" location="samples/server/petstore/php-laravel/composer.json:24">
P1: phpunit.xml.dist still targets PHPUnit 9.5 but the dependency is now ^12.0. The config uses a PHPUnit 9 schema, removed attributes (convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions), and the legacy <coverage><include> structure that was replaced by <source> in PHPUnit 10.1+. Running vendor/bin/phpunit with this config will produce errors. Run vendor/bin/phpunit --migrate-configuration or update the config to the PHPUnit 12 format.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| @@ -16,12 +16,12 @@ | |||
| } | |||
Contributor
There was a problem hiding this comment.
P1: phpunit.xml.dist still targets PHPUnit 9.5 but the dependency is now ^12.0. The config uses a PHPUnit 9 schema, removed attributes (convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions), and the legacy structure that was replaced by
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/server/petstore/php-laravel/composer.json, line 24:
<comment>phpunit.xml.dist still targets PHPUnit 9.5 but the dependency is now ^12.0. The config uses a PHPUnit 9 schema, removed attributes (convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions), and the legacy <coverage><include> structure that was replaced by <source> in PHPUnit 10.1+. Running vendor/bin/phpunit with this config will produce errors. Run vendor/bin/phpunit --migrate-configuration or update the config to the PHPUnit 12 format.</comment>
<file context>
@@ -21,7 +21,7 @@
},
"require-dev": {
- "phpunit/phpunit": "^9.5"
+ "phpunit/phpunit": "^12.0"
},
"autoload": {
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update php laravel to latest stable version
test php with php 8.3, 8.4 (8.2 will be reached EOL in ~6 months)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Upgraded PHP to
^8.3,laravel/frameworkto^13.0, andphpunit/phpunitto^12.0in the Laravel generator and samples; CI tests 8.3/8.4 and runs PHPUnit only when config/tests exist; added comments to.openapi-generator-ignore.Written for commit eb62aa3. Summary will update on new commits.